From e2f129d46d8c6f63ab6bc060f388b065c06accd6 Mon Sep 17 00:00:00 2001 From: easion101 <87601093+easion101@users.noreply.github.com> Date: Sun, 18 Jul 2021 17:58:31 +0800 Subject: [PATCH] failed to install Node 1. line 99 tries to extract a zipped file which would be downloaded later(at line 105), and then line 112 will extract that file again, except that it's using a wrong argument "zxvf". fix: comment out line 99, fix line 112 args from "zxvf" to "xvf" 2. typo at line 116, I think it should be "NODE_DIR", it was "NVIM_DIR", which hasn't be installed yet. --- docs/Nvim_setup.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/Nvim_setup.sh b/docs/Nvim_setup.sh index 017e7de..89e6aca 100755 --- a/docs/Nvim_setup.sh +++ b/docs/Nvim_setup.sh @@ -96,7 +96,7 @@ NODE_LINK="https://nodejs.org/dist/v14.15.4/node-v14.15.4-linux-x64.tar.xz" mkdir -p $HOME/tools # extract node to a custom directory, the directory should exist. -tar xvf node-v14.15.4-linux-x64.tar.xz --directory=$HOME/tools +# tar xvf node-v14.15.4-linux-x64.tar.xz --directory=$HOME/tools if [[ -z "$(command -v node)" ]]; then echo "Install Nodejs" @@ -109,11 +109,11 @@ if [[ -z "$(command -v node)" ]]; then echo "Creating nodejs directory under tools directory" mkdir -p "$NODE_DIR" echo "Extracting to $HOME/tools/nodejs directory" - tar zxvf "$NODE_SRC_NAME" -C "$NODE_DIR" --strip-components 1 + tar xvf "$NODE_SRC_NAME" -C "$NODE_DIR" --strip-components 1 fi if [[ "$ADD_TO_SYSTEM_PATH" = true ]] && [[ "$USE_BASH_SHELL" = true ]]; then - echo "export PATH=\"$NVIM_DIR/bin:\$PATH\"" >> "$HOME/.bash_profile" + echo "export PATH=\"$NODE_DIR/bin:\$PATH\"" >> "$HOME/.bash_profile" fi else echo "Nodejs is already installed. Skip installing it."