clear the build warnings and fail on new ones

A clean build now emits no warnings of its own, and Kotlin `allWarningsAsErrors` plus lint `warningsAsErrors` stop new ones from sneaking back in. - Kotlin: give SearchFilter's @StringRes parameter an explicit @param: target; use safe calls for File.parentFile in StringResourcesTest. - Packaging: keep debug symbols for the prebuilt .so files that have no symbol table, which is what the "unable to strip" warning was about. - Lint: move `modifier` to the first optional parameter across the Compose screens, use mutableIntStateOf for int state, read Resources via LocalResources, use the KTX Bitmap.get/String.toUri, drop the unused ic_action_name and ic_stat_name bitmaps and the dead -v24 qualifier on the notification vector, fix the pt-BR "album" accents and the unused Vietnamese/Thai plural quantities, and suppress the intentional cleartext/user-certificate, backup, exported-service and plural-candidate findings. Disable the version-update nags, which the dependency-update process owns. The AboutLibraries plugin still resolves the variant classpaths during configuration, so AGP keeps warning about that one; upstream in mikepenz/AboutLibraries#1369.
2026-11-11 07:29:14 +01:00 · 2026-10-08 10:27:09 +00:00
parent eef94eff63
commit 05de10c912
38 changed files with 85 additions and 50 deletions
@@ -1,8 +1,10 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
    android:width="24dp"
    android:height="24dp"
    android:viewportWidth="300"
-    android:viewportHeight="300">
+    android:viewportHeight="300"
+    tools:ignore="UnusedResources">
  <group android:translateY="40.25">
    <path
        android:pathData="m23.84,-0c-12.76,0 -23.44,13 -23.65,25.12 -0.42,79.03 0,160.73 0,170.4 0,12.59 9.8,23.99 23.41,23.99l253.58,0c11.4,0 22.66,-12.38 22.66,-22.79L299.84,24.12c0,-10.8 -10.24,-23.81 -21.84,-23.81 -11.6,0 -254.16,-0.31 -254.16,-0.31zM39.05,25.28c0,0 217.71,0.71 223.67,0.71 6.07,0 12.17,6.83 12.17,12.06l0,142.25c0,8.97 -6.97,14.63 -12.48,14.64l-33.42,0.07c-5.32,0.01 -9.93,-7.19 -11.35,-10.61 -1.89,-4.55 -11.08,-25.75 -12.1,-28.1 -0.6,-1.38 -2.9,-2.83 -5.89,-2.83L98.33,153.45c-2.68,0 -4.89,2.87 -5.67,4.71 -1.12,2.66 -9.02,21.39 -11.63,27.57 -2.73,6.46 -4.37,9.06 -11.47,9.06l-30.97,0c-7.44,0 -13.69,-7.17 -13.67,-15.18l0.28,-139.51c0,-6.88 5.54,-14.83 13.85,-14.83z"
@@ -10,8 +10,8 @@
    <string name="navigation_tabs_library">Biblioteca</string>
    <string name="navigation_tabs_settings">Configurações</string>
    <plurals name="resources_album_count">
-        <item quantity="one">%1$d album</item>
-        <item quantity="other">%1$d albums</item>
+        <item quantity="one">%1$d álbum</item>
+        <item quantity="other">%1$d álbuns</item>
    </plurals>
    <string name="resources_filter_album">Álbum</string>
    <string name="resources_filter_artist">Artista</string>
@@ -42,7 +42,7 @@
    <string name="settings_servers_fields_password">Senha</string>
    <string name="settings_servers_fields_username">Usuário</string>
    <string name="navigation_tabs_home">Home</string>
-    <string name="resources_album_name">Albums</string>
+    <string name="resources_album_name">Álbuns</string>
    <string name="resources_artist_name">Artists</string>
    <string name="resources_playlist_name">Playlists</string>
 </resources>
@@ -17,7 +17,6 @@
    <string name="resources_filter_genre">ประเภท</string>
    <string name="resources_filter_starred">ให้ดาว</string>
    <plurals name="resources_song_count">
-        <item quantity="one">%1$d เพลง</item>
        <item quantity="other">%1$d เพลง</item>
    </plurals>
    <string name="resources_sort_by_artist">ศิลปิน</string>
@@ -10,7 +10,6 @@
    <string name="navigation_tabs_library">Thư viện</string>
    <string name="navigation_tabs_settings">Cài đặt</string>
    <plurals name="resources_album_count">
-        <item quantity="one">%1$d album</item>
        <item quantity="other">%1$d album</item>
    </plurals>
    <string name="resources_filter_album">Theo album</string>
@@ -18,7 +17,6 @@
    <string name="resources_filter_genre">Theo thể loại</string>
    <string name="resources_filter_starred">Theo yêu thích</string>
    <plurals name="resources_song_count">
-        <item quantity="one">%1$d bài hát</item>
        <item quantity="other">%1$d bài hát</item>
    </plurals>
    <string name="resources_sort_by_artist">Nghệ sĩ</string>
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools">
    <string name="app_name">subtracks</string>
    <string name="download_channel_description">Progress while songs download</string>

@@ -124,7 +124,7 @@
    <string name="search">Search</string>
    <string name="search_this_list">Search this list</string>
    <string name="search_songs">Songs</string>
-    <string name="search_min_length">Type at least %1$d characters to search.</string>
+    <string name="search_min_length" tools:ignore="PluralsCandidate">Type at least %1$d characters to search.</string>
    <string name="search_no_results">No results for “%1$s”.</string>
    <string name="sort_by">Sort by</string>
    <string name="sort_ascending">Sort ascending</string>
@@ -245,7 +245,7 @@
    <string name="error_server_unknown">Unknown error</string>
    <string name="error_server_malformed">Malformed response from the server</string>
    <string name="error_server_truncated">Truncated response from the server</string>
-    <string name="error_library_too_large">Library is too large to sync: it exceeds %1$d rows</string>
+    <string name="error_library_too_large" tools:ignore="PluralsCandidate">Library is too large to sync: it exceeds %1$d rows</string>
    <string name="error_http">HTTP %1$d</string>

    <string name="home_section_recently_played_artists">Recently played artists</string>
@@ -1,9 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
-<network-security-config>
-    <base-config cleartextTrafficPermitted="true">
+<network-security-config xmlns:tools="http://schemas.android.com/tools">
+    <base-config
+        cleartextTrafficPermitted="true"
+        tools:ignore="InsecureBaseConfiguration">
        <trust-anchors>
            <certificates src="system" />
-            <certificates src="user" />
+            <certificates
+                src="user"
+                tools:ignore="AcceptsUserCertificates" />
        </trust-anchors>
    </base-config>
 </network-security-config>