address review: keep the notification tap when the activity is recreated

This commit is contained in:
austinried
2026-10-04 00:30:07 +00:00
parent b3cad97869
commit 0cd6f30c88
6 changed files with 63 additions and 50 deletions
@@ -9,6 +9,7 @@ import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.activity.enableEdgeToEdge
import androidx.activity.result.contract.ActivityResultContracts
import androidx.activity.viewModels
import androidx.core.content.ContextCompat
import com.subtracks.ui.NowPlayingLauncher
import com.subtracks.ui.SubtracksRoot
@@ -16,6 +17,7 @@ import com.subtracks.ui.theme.SubtracksTheme
import org.koin.core.context.GlobalContext
class MainActivity : ComponentActivity() {
private val launchViewModel: NowPlayingLaunchViewModel by viewModels()
private val nowPlayingLauncher: NowPlayingLauncher by lazy { GlobalContext.get().get() }
private val requestNotifications =
@@ -25,9 +27,7 @@ class MainActivity : ComponentActivity() {
super.onCreate(savedInstanceState)
requestNotificationPermission()
enableEdgeToEdge()
if (shouldRecordNowPlayingLaunch(intent?.action, restoringState = savedInstanceState != null)) {
nowPlayingLauncher.request()
}
if (launchViewModel.claimLaunch(intent?.action)) nowPlayingLauncher.request()
setContent {
SubtracksTheme {
SubtracksRoot()
@@ -38,7 +38,10 @@ class MainActivity : ComponentActivity() {
override fun onNewIntent(intent: Intent) {
super.onNewIntent(intent)
setIntent(intent)
if (intent.action == ACTION_OPEN_NOW_PLAYING) nowPlayingLauncher.request()
if (intent.action == ACTION_OPEN_NOW_PLAYING) {
launchViewModel.markHandled()
nowPlayingLauncher.request()
}
}
private fun requestNotificationPermission() {
@@ -53,8 +56,3 @@ class MainActivity : ComponentActivity() {
const val ACTION_OPEN_NOW_PLAYING = "com.subtracks.action.OPEN_NOW_PLAYING"
}
}
internal fun shouldRecordNowPlayingLaunch(
action: String?,
restoringState: Boolean,
): Boolean = action == MainActivity.ACTION_OPEN_NOW_PLAYING && !restoringState
@@ -0,0 +1,17 @@
package com.subtracks
import androidx.lifecycle.ViewModel
class NowPlayingLaunchViewModel : ViewModel() {
private var launchHandled = false
fun claimLaunch(action: String?): Boolean {
if (action != MainActivity.ACTION_OPEN_NOW_PLAYING || launchHandled) return false
launchHandled = true
return true
}
fun markHandled() {
launchHandled = true
}
}
@@ -301,11 +301,10 @@ private fun MainNavigation() {
settleJob?.cancel()
nowPlayingOpen = false
nowPlayingProgress = 0f
return@LaunchedEffect
}
}
LaunchedEffect(playerVisible) {
if (!playerVisible) return@LaunchedEffect
nowPlayingLauncher.openNowPlaying.collect {
showingQueue = false
if (navController.currentDestination?.route in DETAIL_ROUTES) {
navController.popBackStack(Routes.LIBRARY, inclusive = false)
}
@@ -4,7 +4,7 @@ import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.receiveAsFlow
class NowPlayingLauncher {
internal class NowPlayingLauncher {
private val requests = Channel<Unit>(Channel.CONFLATED)
val openNowPlaying: Flow<Unit> = requests.receiveAsFlow()