give the album detail artist line a full touch target

The subtitle was a bare bodyMedium line: 20dp tall and only as wide as the text. It now sits in a full-width target spanning the 4dp lead-in and the 20dp gap below it, so the row clears 48dp while the text stays where it was. The album title is deliberately not part of it, unlike now playing: it can wrap to two lines, so tapping it should not jump to the artist. The controls row moves down 4dp, the only layout delta. AlbumDetailTapsTest covers the tap, the 48dp minimum (fails on a 20dp node) and that the title carries no click action.
2026-11-10 23:21:59 +01:00 · 2026-10-04 00:30:01 +00:00
parent a296443109
commit 17a41fd579
2 changed files with 120 additions and 19 deletions
@@ -0,0 +1,84 @@
+package com.subtracks.ui.library
+
+import androidx.activity.ComponentActivity
+import androidx.compose.ui.test.assertCountEquals
+import androidx.compose.ui.test.assertHeightIsAtLeast
+import androidx.compose.ui.test.filter
+import androidx.compose.ui.test.hasClickAction
+import androidx.compose.ui.test.junit4.v2.createAndroidComposeRule
+import androidx.compose.ui.test.onAllNodesWithText
+import androidx.compose.ui.test.onNodeWithText
+import androidx.compose.ui.test.performClick
+import androidx.compose.ui.unit.dp
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.subtracks.data.model.Album
+import com.subtracks.data.model.CoverArtRef
+import com.subtracks.ui.theme.SubtracksTheme
+import org.junit.Assert.assertTrue
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.annotation.GraphicsMode
+
+@RunWith(AndroidJUnit4::class)
+@GraphicsMode(GraphicsMode.Mode.NATIVE)
+class AlbumDetailTapsTest {
+    @get:Rule
+    val composeRule = createAndroidComposeRule<ComponentActivity>()
+
+    private val album =
+        Album(
+            sourceId = 1,
+            id = "al-kid-a",
+            artistId = "ar-radiohead",
+            name = "Kid A",
+            albumArtist = "Radiohead",
+            created = 0,
+            coverArt = "art-al-kid-a",
+            genre = null,
+            year = 2000,
+            starred = null,
+            songCount = 1,
+        )
+
+    private fun render(onArtistClick: (() -> Unit)? = null) {
+        composeRule.setContent {
+            SubtracksTheme {
+                AlbumDetailScreen(
+                    album = album,
+                    songs = emptyList(),
+                    coverArt = { id, _ -> id?.let { CoverArtRef(it, "test:$it") } },
+                    artwork = null,
+                    onBack = {},
+                    onSongClick = {},
+                    onArtistClick = onArtistClick,
+                )
+            }
+        }
+    }
+
+    @Test
+    fun tappingTheArtistOpensTheArtist() {
+        var opened = false
+        render(onArtistClick = { opened = true })
+
+        composeRule.onNodeWithText("Radiohead \u00B7 2000").performClick()
+
+        assertTrue("the artist name should open the artist", opened)
+    }
+
+    @Test
+    fun theArtistTargetIsAtLeastTheMinimumTouchSize() {
+        render(onArtistClick = {})
+
+        composeRule.onNodeWithText("Radiohead \u00B7 2000").assertHeightIsAtLeast(48.dp)
+    }
+
+    @Test
+    fun theAlbumTitleIsNotATapTarget() {
+        render(onArtistClick = {})
+
+        // The app bar repeats the album name, so match the hero title by having no click.
+        composeRule.onAllNodesWithText("Kid A").filter(hasClickAction().not()).assertCountEquals(1)
+    }
+}