Makussu/subtracks
1
0
Fork 0
mirror of https://github.com/austinried/subtracks.git synced 2026-11-11 15:29:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

drop estimateContentLength from stream URLs

Browse Source 
The server's byte estimate can be shorter than the transcoded stream, so the player stops at Content-Length and some tracks end early. Let the server stream the true length instead.
This commit is contained in:
austinried
2026-10-04 00:29:59 +00:00
parent 95216143dc
commit 258dde6c86
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/kotlin/com/subtracks/data/source/subsonic/SubsonicSource.kt
-2
View File
@@ -136,8 +136,6 @@ class SubsonicSource(
"stream", "stream",
buildMap { buildMap {
put("id", songId) put("id", songId)
val transcodes = maxBitrate > 0 || !streamFormat.isNullOrEmpty()
if (transcodes) put("estimateContentLength", "true")
if (maxBitrate > 0) put("maxBitRate", maxBitrate.toString()) if (maxBitrate > 0) put("maxBitRate", maxBitrate.toString())
streamFormat?.takeIf { it.isNotEmpty() }?.let { put("format", it) } streamFormat?.takeIf { it.isNotEmpty() }?.let { put("format", it) }
}, },
app/src/test/kotlin/com/subtracks/data/source/subsonic/SubsonicSourceTest.kt
+2 -2
View File
@@ -416,7 +416,7 @@ class SubsonicSourceTest {
val uri = SubsonicSource(1, client(), maxBitrate = 128).streamUri("s1").toString() val uri = SubsonicSource(1, client(), maxBitrate = 128).streamUri("s1").toString()
assertTrue(uri, uri.contains("maxBitRate=128")) assertTrue(uri, uri.contains("maxBitRate=128"))
assertTrue(uri, uri.contains("estimateContentLength=true")) assertFalse(uri, uri.contains("estimateContentLength"))
} }
@Test @Test
@@ -433,7 +433,7 @@ class SubsonicSourceTest {
val uri = SubsonicSource(1, client(), streamFormat = "opus").streamUri("s1").toString() val uri = SubsonicSource(1, client(), streamFormat = "opus").streamUri("s1").toString()
assertTrue(uri, uri.contains("format=opus")) assertTrue(uri, uri.contains("format=opus"))
assertTrue(uri, uri.contains("estimateContentLength=true")) assertFalse(uri, uri.contains("estimateContentLength"))
} }
private fun client() = private fun client() =