artists: tighten the header and drop the dead star/more on track artists

Lift the type label to the artist name's inset and centre the album count
on the star/more row. A credited track artist has no artists row, so its
star is disabled and more does nothing; hide both there.

app/src/main/kotlin/com/subtracks/ui/library/ArtistDetailScreen.kt

@@ -363,22 +363,25 @@ fun ArtistDetailScreen(
                                     }
                                 }
                             }
-                            Row(
+                            Column(
-                                modifier = Modifier.fillMaxWidth().padding(start = 16.dp, end = 8.dp, top = 34.dp, bottom = 0.dp),
+                                modifier = Modifier.fillMaxWidth().padding(start = 16.dp, end = 8.dp, top = TITLE_INSET),
-                                verticalAlignment = Alignment.CenterVertically,
                             ) {
-                                Column(Modifier.weight(1f)) {
                                 Text(
                                     text = artistType,
                                     style = MaterialTheme.typography.labelLarge,
                                     color = MaterialTheme.colorScheme.onSurfaceVariant,
                                 )
+                                Row(
+                                    modifier = Modifier.fillMaxWidth(),
+                                    verticalAlignment = Alignment.CenterVertically,
+                                ) {
                                     Text(
                                         text = pluralStringResource(R.plurals.resources_album_count, albumCount.toInt(), albumCount),
                                         style = MaterialTheme.typography.bodyLarge,
                                         color = MaterialTheme.colorScheme.onSurfaceVariant,
+                                        modifier = Modifier.weight(1f),
                                     )
-                                }
+                                    if (artist != null) {
                                         IconButton(
                                             onClick = { onToggleStar?.invoke() },
                                             enabled = onToggleStar != null,
@@ -403,6 +406,8 @@ fun ArtistDetailScreen(
                                     }
                                 }
                             }
+                        }
+                    }
                     itemsIndexed(albums, key = { _, album -> album.id }) { index, album ->
                         val art = coverArt(album.coverArt, false)
                         val thumbnail = coverArt(album.coverArt, true)

app/src/test/kotlin/com/subtracks/ui/library/ArtistDetailScreenTest.kt

@@ -1,8 +1,11 @@
 package com.subtracks.ui.library
 
 import androidx.activity.ComponentActivity
+import androidx.compose.ui.test.assertCountEquals
 import androidx.compose.ui.test.junit4.v2.createAndroidComposeRule
+import androidx.compose.ui.test.onAllNodesWithContentDescription
 import androidx.compose.ui.test.onAllNodesWithText
+import androidx.compose.ui.test.onNodeWithContentDescription
 import androidx.compose.ui.test.onNodeWithText
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import com.subtracks.data.model.Artist
@@ -45,6 +48,7 @@ class ArtistDetailScreenTest {
 
         composeRule.onAllNodesWithText("Guest")[0].assertExists()
         composeRule.onNodeWithText("Artist").assertExists()
+        composeRule.onAllNodesWithContentDescription("More options").assertCountEquals(0)
     }
 
     @Test
@@ -56,5 +60,6 @@ class ArtistDetailScreenTest {
         )
 
         composeRule.onNodeWithText("Album artist").assertExists()
+        composeRule.onNodeWithContentDescription("More options").assertExists()
     }
 }