Makussu/subtracks
1
0
Fork 0
mirror of https://github.com/austinried/subtracks.git synced 2026-11-15 00:42:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

ui: cover the artist section split in tests

Browse Source 
Assert the combined meta line while loading, cover the downloaded partition
and the plural album/song credit branches, share the album-credit id query
with its plan test, and put the meta line through a translatable string.
This commit is contained in:
austinried
2026-10-19 03:14:13 +00:00
parent 8cdbe64942
commit 3198a94df3
8 changed files with 116 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/test/kotlin/com/subtracks/data/db/LibraryDaoTest.kt
+6 -5
View File
@@ -548,17 +548,18 @@ class LibraryDaoTest {
@Test
fun albumCreditIdsFindCreditsThroughArtistIndexes() =
runTest {
val plan =
plan(
"SELECT DISTINCT albumId FROM ($CREDITED_ALBUM_ROWS) " +
"WHERE artistId = :artistId AND albumCredit = 1",
)
val plan = plan(ALBUM_CREDIT_ALBUM_IDS)
assertTrue(plan, plan.contains("USING INDEX index_albums_sourceId_artistId (sourceId=? AND artistId=?)"))
assertTrue(
plan,
plan.contains("USING INDEX index_album_artists_sourceId_artistId (sourceId=? AND artistId=?)"),
)
assertTrue(plan, plan.contains("USING INDEX index_songs_sourceId_artistId (sourceId=? AND artistId=?)"))
assertTrue(
plan,
plan.contains("USING INDEX index_song_artists_sourceId_artistId (sourceId=? AND artistId=?)"),
)
assertFalse(plan, plan.contains("SCAN albums"))
assertFalse(plan, plan.contains("SCAN songs"))
}
app/src/test/kotlin/com/subtracks/data/repo/LibraryRepositoryTest.kt
+33
View File
@@ -12,7 +12,9 @@ import com.subtracks.cancelAndJoinBlocking
import com.subtracks.data.db.SubtracksDatabase
import com.subtracks.data.download.ArtworkStore
import com.subtracks.data.model.Album
import com.subtracks.data.model.DownloadStatus
import com.subtracks.data.model.Song
import com.subtracks.data.model.SongDownload
import com.subtracks.data.model.Source
import com.subtracks.data.prefs.AlbumSort
import com.subtracks.data.prefs.StarredFilter
@@ -231,6 +233,37 @@ class LibraryRepositoryTest {
assertEquals(2, albums.count)
}
@Test
fun downloadedArtistAlbumsKeepPerCreditVisibility() =
runBlocking {
val sourceId = 1L
db.sourcesDao().upsertSource(
Source(id = sourceId, name = "test", address = "http://localhost", isActive = true, createdAt = 0),
)
db.libraryDao().upsertAlbums(
listOf(
seedAlbum(sourceId, 1),
seedAlbum(sourceId, 2).copy(artistId = "ar2"),
),
)
db.libraryDao().upsertSongs(
listOf(
seedSong(sourceId).copy(albumId = "al-0001"),
seedSong(sourceId).copy(id = "s2", albumId = "al-0002"),
),
)
db.downloadDao().upsert(SongDownload(sourceId, "s1", DownloadStatus.Completed))
val before = repository.artistAlbums(sourceId, "ar1", downloaded = true).first()
assertEquals(listOf("al-0001"), before.albumCredits.map { it.id })
assertEquals(emptyList<String>(), before.appearances.map { it.id })
db.downloadDao().upsert(SongDownload(sourceId, "s2", DownloadStatus.Completed))
val after = repository.artistAlbums(sourceId, "ar1", downloaded = true).first()
assertEquals(listOf("al-0001"), after.albumCredits.map { it.id })
assertEquals(listOf("al-0002"), after.appearances.map { it.id })
}
private suspend fun awaitRefreshes(
presenter: RecordingPresenter,
target: Int,
app/src/test/kotlin/com/subtracks/data/sync/SyncServiceTest.kt
+65
View File
@@ -1640,6 +1640,71 @@ class SyncServiceTest {
)
}
@Test
fun albumCreditIdsFollowPluralCredits() =
runTest {
insertSource()
val source =
FakeMusicSource(
artists = listOf(artist("a1", "A"), artist("a2", "B")),
albums =
listOf(
album("al1").copy(artistId = "a1", artists = listOf(ArtistRef("a1", "A"))),
album("al2").copy(artistId = "a2", artists = listOf(ArtistRef("a2", "B"))),
album("al3").copy(
artistId = "a2",
artists = listOf(ArtistRef("a1", "A"), ArtistRef("a2", "B")),
),
),
songs =
listOf(
song("s1").copy(
albumId = "al1",
artistId = "a1",
artists = listOf(ArtistRef("a1", "A")),
),
song("s2").copy(
albumId = "al2",
artistId = "a2",
artists = listOf(ArtistRef("a2", "B"), ArtistRef("a1", "A")),
),
song("s3").copy(
albumId = "al3",
artistId = "a2",
artists = listOf(ArtistRef("a1", "A"), ArtistRef("a2", "B")),
),
),
)
SyncService(db, source).sync()
assertEquals(
listOf("al1", "al3"),
db
.libraryDao()
.albumCreditAlbumIds(1, "a1")
.first()
.sorted(),
)
assertEquals(
listOf("al2", "al3"),
db
.libraryDao()
.albumCreditAlbumIds(1, "a2")
.first()
.sorted(),
)
assertEquals(
listOf("al1", "al2", "al3"),
db
.libraryDao()
.albumsForArtist(1, "a1")
.first()
.map { it.id }
.sorted(),
)
}
@Test
fun everyArtistConsumerAgreesOnTheCreditedSet() =
runTest {
app/src/test/kotlin/com/subtracks/ui/library/ArtistDetailScreenTest.kt
+2 -3
View File
@@ -104,9 +104,8 @@ class ArtistDetailScreenTest {
albumsLoaded = false,
)
composeRule.onNodeWithText("Artist").assertDoesNotExist()
composeRule.onNodeWithText("Album artist").assertDoesNotExist()
composeRule.onNodeWithText("0 albums").assertDoesNotExist()
composeRule.onNodeWithText("Artist · 0 albums").assertDoesNotExist()
composeRule.onNodeWithText("Album artist · 0 albums").assertDoesNotExist()
}
private fun album(