React Query refactor (#91)

* initial react-query experiments

* use queries for item screens

send the data we do have over routing to prepopulate (album/playlist)
use number for starred because sending Date freaks out react-navigation

* add in equiv. song cover art fix

* reorg, switch artistview over

start mapping song cover art when any are available

* refactor useStar to queries

fix caching for starred items and album cover art

* add hook to reset queries on server change

* refactor search to use query

* fix song cover art setting

* use query for artistInfo

* remove last bits of library state

* cleanup

* use query key factory

already fixed one wrong key...

* require coverart size

* let's try no promise queues on these for now

* image cache uses query

* perf fix for playlist parsing

also use placeholder data so we don't have to deal with staleness

* drill that disabled

also list controls doesn't need its own songs hook/copy

* switch to react-native-blob-util for downloads

slightly slower but allows us to use DownloadManager, which backgrounds downloads so they are no longer corrupted when the app suspends

* add a fake "top songs" based on artist search

then sorted by play count/ratings
artistview should load now even if topSongs fails

* try not to swap between topSongs/search on refetch

set queueContext by song list so the index isn't off if the list changes

* add content type validation for file fetching

also try to speed up existing file return by limiting fs ops

* if the HEAD fails, don't queue the download

* clean up params

* reimpl clear image cache

* precompute contextId

prevents wrong "is playing" when any mismatch between queue and list

* clear images from all servers

use external files dir instead of cache

* fix pressable disabled flicker

don't retry topsongs on failure
try to optimize setqueue and fixcoverart a bit

* wait for queries during clear

* break out fetchExistingFile from fetchFile

allows to tell if file is coming from disk or not
only show placeholder/loading spinner if actually fetching image

* forgot these wouldn't do anything with objects

* remove query cache when switching servers

* add content-disposition extension gathering

add support for progress hook (needs native support still)

* added custom RNBU pkg with progress changes

* fully unmount tabs when server changes

prevents unwanted requests, gives fresh start on switch
fix fixCoverArt not re-rendering in certain cases on search

* use serverId from fetch deps

* fix lint

* update licenses

* just use the whole lodash package

* make using cache buster optional
This commit is contained in:
austinried
2022-04-11 09:40:51 +09:00
committed by GitHub
parent ccc7f44957
commit 335f30b0d2
48 changed files with 2205 additions and 1800 deletions
+32 -9
View File
@@ -2,6 +2,7 @@ import { AlbumFilterSettings, ArtistFilterSettings, Server } from '@app/models/s
import { ById } from '@app/models/state'
import { GetStore, SetStore } from '@app/state/store'
import { SubsonicApiClient } from '@app/subsonic/api'
import uuid from 'react-native-uuid'
export type SettingsSlice = {
settings: {
@@ -21,13 +22,17 @@ export type SettingsSlice = {
maxBitrateMobile: number
minBuffer: number
maxBuffer: number
cacheBuster: string
}
client?: SubsonicApiClient
resetServer: boolean
changeCacheBuster: () => void
setActiveServer: (id: string | undefined, force?: boolean) => Promise<void>
addServer: (server: Server) => Promise<void>
removeServer: (id: string) => Promise<void>
addServer: (server: Server) => void
removeServer: (id: string) => void
updateServer: (server: Server) => void
setScrobble: (scrobble: boolean) => void
@@ -42,6 +47,10 @@ export type SettingsSlice = {
setLibraryArtistFiler: (filter: ArtistFilterSettings) => void
}
export function newCacheBuster(): string {
return (uuid.v4() as string).split('-')[0]
}
export const createSettingsSlice = (set: SetStore, get: GetStore): SettingsSlice => ({
settings: {
servers: {},
@@ -66,6 +75,15 @@ export const createSettingsSlice = (set: SetStore, get: GetStore): SettingsSlice
maxBitrateMobile: 192,
minBuffer: 6,
maxBuffer: 60,
cacheBuster: newCacheBuster(),
},
resetServer: false,
changeCacheBuster: () => {
set(store => {
store.settings.cacheBuster = newCacheBuster()
})
},
setActiveServer: async (id, force) => {
@@ -84,17 +102,24 @@ export const createSettingsSlice = (set: SetStore, get: GetStore): SettingsSlice
return
}
get().prepareCache(newActiveServer.id)
set(state => {
state.resetServer = true
})
set(state => {
state.settings.activeServerId = newActiveServer.id
state.client = new SubsonicApiClient(newActiveServer)
get().resetLibrary(state)
})
set(state => {
state.resetServer = false
})
},
addServer: async server => {
await get().createCache(server.id)
addServer: server => {
const serverIds = Object.keys(get().settings.servers)
server.id =
serverIds.length === 0 ? '0' : (serverIds.map(i => parseInt(i, 10)).sort((a, b) => b - a)[0] + 1).toString()
set(state => {
state.settings.servers[server.id] = server
@@ -105,9 +130,7 @@ export const createSettingsSlice = (set: SetStore, get: GetStore): SettingsSlice
}
},
removeServer: async id => {
await get().removeCache(id)
removeServer: id => {
set(state => {
delete state.settings.servers[id]
})