feat: add a keep-screen-on toggle for now playing

A screen timeout mid-album is a common complaint for a music player: the phone lies on a table while art or lyrics are on screen and the display sleeps. Add a Settings toggle under Playback, off by default, that holds the screen awake while now playing is open. The flag rides on the now playing overlay through Compose's keepScreenOn modifier, and since the overlay is only composed while expanded, collapsing it releases the flag without any window-flag lifecycle handling. Closes austinried/subtracks#201
2026-11-15 00:42:54 +01:00 · 2026-10-17 01:14:48 +00:00
parent b2c66bf03e
commit 538cb4177a
7 changed files with 147 additions and 1 deletions
@@ -155,6 +155,24 @@ class UserPreferencesTest {
            file.delete()
        }

+    @Test
+    fun keepScreenOnDefaultsOffAndRoundTrips() =
+        runTest {
+            val file = File.createTempFile("user-prefs", ".preferences_pb").apply { delete() }
+            val store = PreferenceDataStoreFactory.create(scope = backgroundScope) { file }
+            val prefs = UserPreferences(store)
+
+            assertEquals(false, prefs.keepScreenOn().first())
+
+            prefs.setKeepScreenOn(true)
+            assertEquals(true, prefs.keepScreenOn().first())
+
+            prefs.setKeepScreenOn(false)
+            assertEquals(false, prefs.keepScreenOn().first())
+
+            file.delete()
+        }
+
    @Test
    fun lastSeedRoundTripsWithAndWithoutASecondary() =
        runTest {
@@ -0,0 +1,73 @@
+package com.subtracks.ui.settings
+
+import androidx.activity.ComponentActivity
+import androidx.compose.ui.test.hasScrollToNodeAction
+import androidx.compose.ui.test.hasText
+import androidx.compose.ui.test.junit4.v2.createAndroidComposeRule
+import androidx.compose.ui.test.onAllNodesWithText
+import androidx.compose.ui.test.onNodeWithText
+import androidx.compose.ui.test.performClick
+import androidx.compose.ui.test.performScrollToNode
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.github.takahirom.roborazzi.RobolectricDeviceQualifiers
+import com.subtracks.data.prefs.StreamQuality
+import com.subtracks.ui.theme.SubtracksTheme
+import org.junit.Assert.assertEquals
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.annotation.Config
+import org.robolectric.annotation.GraphicsMode
+
+@RunWith(AndroidJUnit4::class)
+@GraphicsMode(GraphicsMode.Mode.NATIVE)
+@Config(qualifiers = RobolectricDeviceQualifiers.PixelXL)
+class SettingsScreenTest {
+    @get:Rule
+    val composeRule = createAndroidComposeRule<ComponentActivity>()
+
+    @Test
+    fun theKeepScreenOnRowToggles() {
+        var requested: Boolean? = null
+        composeRule.setContent {
+            SubtracksTheme {
+                SettingsScreen(
+                    sources = emptyList(),
+                    activeSourceId = null,
+                    wifiQuality = StreamQuality(),
+                    mobileQuality = StreamQuality(),
+                    syncConcurrency = 1,
+                    downloadQuality = StreamQuality(),
+                    downloadOverMetered = false,
+                    scrobbling = false,
+                    keepScreenOn = false,
+                    onSelectSource = {},
+                    onEditServer = {},
+                    onWifiQualityChange = {},
+                    onMobileQualityChange = {},
+                    onSyncConcurrencyChange = {},
+                    onDownloadQualityChange = {},
+                    onDownloadOverMeteredChange = {},
+                    onScrobblingChange = {},
+                    onKeepScreenOnChange = { requested = it },
+                    onAddServer = {},
+                    onOpenDownloads = {},
+                    onOpenLicenses = {},
+                    onShareLogs = {},
+                    onBack = {},
+                )
+            }
+        }
+        awaitText("Add server")
+        composeRule.onNode(hasScrollToNodeAction()).performScrollToNode(hasText("Keep screen on"))
+        composeRule.onNodeWithText("Keep screen on").performClick()
+        composeRule.waitForIdle()
+        assertEquals(true, requested)
+    }
+
+    private fun awaitText(text: String) {
+        composeRule.waitUntil(timeoutMillis = 5_000) {
+            composeRule.onAllNodesWithText(text).fetchSemanticsNodes().isNotEmpty()
+        }
+    }
+}