Makussu/subtracks
1
0
Fork 0
mirror of https://github.com/austinried/subtracks.git synced 2026-11-11 07:29:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

settings: name the toolkit in the slider comments

Browse Source 
The in-repo comment rule allows a comment only when it names an external
system, version or issue, so both of these now name Compose Material 3,
which is what they are actually about.
This commit is contained in:
austinried
2026-10-16 13:07:12 +00:00
parent d245da20a4
commit 5b6c0ef45c
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/kotlin/com/subtracks/ui/settings/ReplayGainControls.kt
+3 -3
View File
@@ -12,9 +12,9 @@ internal const val REPLAY_GAIN_PREAMP_STEP_DB = 0.5f
internal val REPLAY_GAIN_PREAMP_STEPS = internal val REPLAY_GAIN_PREAMP_STEPS =
((MAX_REPLAY_GAIN_PREAMP_DB - MIN_REPLAY_GAIN_PREAMP_DB) / REPLAY_GAIN_PREAMP_STEP_DB).toInt() - 1 ((MAX_REPLAY_GAIN_PREAMP_DB - MIN_REPLAY_GAIN_PREAMP_DB) / REPLAY_GAIN_PREAMP_STEP_DB).toInt() - 1
// Material's slider snaps in pixel space and converts back, so the value it reports is near, but not // Compose Material 3's Slider snaps in pixel space and converts back, so the value it reports is
// on, the grid it was configured with (for example -0.99999905 for -1.0). Snap before showing or // near, but not on, the grid it was configured with (for example -0.99999905 for -1.0). Snap before
// storing it. // showing or storing it.
internal fun snapReplayGainPreampDb(value: Float): Float = (value / REPLAY_GAIN_PREAMP_STEP_DB).roundToInt() * REPLAY_GAIN_PREAMP_STEP_DB internal fun snapReplayGainPreampDb(value: Float): Float = (value / REPLAY_GAIN_PREAMP_STEP_DB).roundToInt() * REPLAY_GAIN_PREAMP_STEP_DB
internal fun stepReplayGainPreampDb( internal fun stepReplayGainPreampDb(
app/src/main/kotlin/com/subtracks/ui/settings/SettingsScreen.kt
+2 -2
View File
@@ -799,8 +799,8 @@ private fun ReplayGainPreampDialog(
onValueChange = { draft = snapReplayGainPreampDb(it) }, onValueChange = { draft = snapReplayGainPreampDb(it) },
valueRange = MIN_REPLAY_GAIN_PREAMP_DB..MAX_REPLAY_GAIN_PREAMP_DB, valueRange = MIN_REPLAY_GAIN_PREAMP_DB..MAX_REPLAY_GAIN_PREAMP_DB,
steps = REPLAY_GAIN_PREAMP_STEPS, steps = REPLAY_GAIN_PREAMP_STEPS,
// 59 steps is a tick every few dps, which reads as a smudge; the snapping is // Compose Material 3 draws one track tick per step, and at 59 steps they
// what matters, so the ticks are not drawn. // smear together, so the ticks are suppressed and the snapping kept.
track = { state -> SliderDefaults.Track(sliderState = state, drawTick = { _, _ -> }) }, track = { state -> SliderDefaults.Track(sliderState = state, drawTick = { _, _ -> }) },
modifier = Modifier.weight(1f), modifier = Modifier.weight(1f),
) )