mirror of
https://github.com/austinried/subtracks.git
synced 2026-11-11 07:29:14 +01:00
Library store refactor (#76)
* start of music store refactor moving stuff into a state cache better separate it from view logic * added paginated list/album list * reworked fetchAlbumList to remove ui state refactored home screen to use new method i broke playing songs somehow, JS thread goes into a loop * don't reset parts manually, do it all at once * fixed perf issue related to too many rerenders rerenders were caused by strict equality check on object/array picks switched artistInfo to new store updated zustand and fixed deprecation warnings * update typescript and use workspace tsc version for vscode * remove old artistInfo * switched to new playlist w/songs removed more unused stuff * remove unused + (slightly) rework search * refactor star * use only original/large imges for covers/artist fix view artist from context menu add loading indicators to song list and artist views (show info we have right away) * set starred/unstar assuming it works and correct state on error * reorg, remove old music slice files * added back fix for song cover art * sort artists by localCompare name * update licenses * fix now playing background grey bar * update react-native-gesture-handler for node-fetch security alert * fix another gradient height grey bar issue * update licenses again * remove thumbnail cache * rename to remove "Library" from methods * Revert "remove thumbnail cache" This reverts commite0db4931f1. * use ids for lists, pull state later * Revert "use only original/large imges for covers/artist" This reverts commitc9aea9065c. * deep equal ListItem props for now this needs a bigger refactor * use immer as middleware * refactor api client to use string method hoping to use this for requestKey/deduping next * use thumbnails in list items * Revert "refactor api client to use string method" This reverts commit234326135b. * rename/cleanup * store servers by id * get rid of settings selectors * renames for clarity remove unused estimateContentLength setting * remove trackplayer selectors * fix migration for library filter settings * fixed shuffle order reporting wrong track/queue * removed the other selectors * don't actually need es6/react for our state * fix slow artist sort on star localeCompare is too slow for large lists
This commit is contained in:
@@ -2,7 +2,6 @@ import CoverArt from '@app/components/CoverArt'
|
||||
import PressableOpacity from '@app/components/PressableOpacity'
|
||||
import { usePause, usePlay } from '@app/hooks/trackplayer'
|
||||
import { useStore } from '@app/state/store'
|
||||
import { selectTrackPlayer } from '@app/state/trackplayer'
|
||||
import colors from '@app/styles/colors'
|
||||
import font from '@app/styles/font'
|
||||
import { useNavigation } from '@react-navigation/native'
|
||||
@@ -12,7 +11,8 @@ import { State } from 'react-native-track-player'
|
||||
import IconFA5 from 'react-native-vector-icons/FontAwesome5'
|
||||
|
||||
const ProgressBar = React.memo(() => {
|
||||
const { position, duration } = useStore(selectTrackPlayer.progress)
|
||||
const position = useStore(store => store.progress.position)
|
||||
const duration = useStore(store => store.progress.duration)
|
||||
|
||||
let progress = 0
|
||||
if (duration > 0) {
|
||||
@@ -41,7 +41,7 @@ const progressStyles = StyleSheet.create({
|
||||
})
|
||||
|
||||
const Controls = React.memo(() => {
|
||||
const state = useStore(selectTrackPlayer.playerState)
|
||||
const state = useStore(store => store.playerState)
|
||||
const play = usePlay()
|
||||
const pause = usePause()
|
||||
|
||||
@@ -78,9 +78,12 @@ const Controls = React.memo(() => {
|
||||
|
||||
const NowPlayingBar = React.memo(() => {
|
||||
const navigation = useNavigation()
|
||||
const track = useStore(selectTrackPlayer.currentTrack)
|
||||
const currentTrackExists = useStore(store => !!store.currentTrack)
|
||||
const coverArt = useStore(store => store.currentTrack?.coverArt)
|
||||
const title = useStore(store => store.currentTrack?.title)
|
||||
const artist = useStore(store => store.currentTrack?.artist)
|
||||
|
||||
const displayStyle: ViewStyle = { display: track ? 'flex' : 'none' }
|
||||
const displayStyle: ViewStyle = { display: currentTrackExists ? 'flex' : 'none' }
|
||||
|
||||
return (
|
||||
<Pressable onPress={() => navigation.navigate('now-playing')} style={[styles.container, displayStyle]}>
|
||||
@@ -89,14 +92,14 @@ const NowPlayingBar = React.memo(() => {
|
||||
<CoverArt
|
||||
type="cover"
|
||||
style={{ height: styles.subContainer.height, width: styles.subContainer.height }}
|
||||
coverArt={track?.coverArt}
|
||||
coverArt={coverArt}
|
||||
/>
|
||||
<View style={styles.detailsContainer}>
|
||||
<Text numberOfLines={1} style={styles.detailsTitle}>
|
||||
{track?.title}
|
||||
{title}
|
||||
</Text>
|
||||
<Text numberOfLines={1} style={styles.detailsAlbum}>
|
||||
{track?.artist}
|
||||
{artist}
|
||||
</Text>
|
||||
</View>
|
||||
<Controls />
|
||||
|
||||
Reference in New Issue
Block a user