Makussu/subtracks
1
0
Fork 0
mirror of https://github.com/austinried/subtracks.git synced 2026-11-10 15:11:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

address review: localize connection errors, tighten i18n guard, drop dead resources

Browse Source 
- AddSourceViewModel resolves SubsonicException.uiMessage too, so malformed/
  HTTP/truncated responses show localized text instead of the raw parser
  message; add a regression test.
- StringResourcesTest now requires an 'other' quantity in every plural and
  asserts exact placeholder (index and conversion) equality, both of which
  could previously pass while crashing getQuantityString at runtime.
- Map the pre-enum song_downloads.error sentences back to their DownloadError
  so existing failed rows keep their specific message.
- Localize the media-session star/unstar button label.
- Remove 12 unreferenced resources (queue name, filter year, sync_failed, and
  the unused codec_* strings; codec labels stay in AudioEncoding).
- Make buildTree's fallback arguments required; only tests used the defaults.
This commit is contained in:
austinried
2026-10-04 00:30:07 +00:00
parent 3162ac07d5
commit 699a6e86f5
33 changed files with 59 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/res/values/strings.xml
-12
View File
@@ -27,12 +27,10 @@
<string name="resources_album_name">Albums</string>
<string name="resources_artist_name">Artists</string>
<string name="resources_playlist_name">Playlists</string>
<string name="resources_queue_name">Queue</string>
<string name="resources_filter_album">Album</string>
<string name="resources_filter_artist">Artist</string>
<string name="resources_filter_genre">Genre</string>
<string name="resources_filter_starred">Starred</string>
<string name="resources_filter_year">Year</string>
<string name="resources_song_list_delete_all_content">%1$s\n\nDeleting will free %2$s</string>
<string name="resources_song_list_delete_all_title">Delete downloads</string>
<string name="resources_sort_by_added">Added</string>
@@ -222,7 +220,6 @@
<string name="star_update_failed">Could not update star</string>
<string name="sync_offline">Offline mode is on</string>
<string name="error_no_server">No server configured</string>
<string name="sync_failed">Sync failed</string>
<string name="sync_failed_detail">Sync failed: %1$s</string>
<string name="error_download_no_space">Not enough space to download</string>
@@ -286,13 +283,4 @@
<item quantity="other">%1$d plays</item>
</plurals>
<string name="codec_mp3" translatable="false">MP3</string>
<string name="codec_aac" translatable="false">AAC</string>
<string name="codec_alac" translatable="false">ALAC</string>
<string name="codec_flac" translatable="false">FLAC</string>
<string name="codec_ogg" translatable="false">Ogg</string>
<string name="codec_vorbis" translatable="false">Vorbis</string>
<string name="codec_opus" translatable="false">Opus</string>
<string name="codec_webm" translatable="false">WebM</string>
<string name="codec_wav" translatable="false">WAV</string>
</resources>