Makussu/subtracks
1
0
Fork 0
mirror of https://github.com/austinried/subtracks.git synced 2026-11-11 15:29:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

ui: pin the downloaded artist album visibility rules

Browse Source 
Distinguish the album-credit rule (any downloaded song on the album) from the
track-credit rule (the credited track itself must be downloaded) in the
repository test, so a swap of those clauses fails.
This commit is contained in:
austinried
2026-10-19 03:18:16 +00:00
parent 3198a94df3
commit 733a4d2941
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/test/kotlin/com/subtracks/data/repo/LibraryRepositoryTest.kt
+14 -7
View File
@@ -250,18 +250,25 @@ class LibraryRepositoryTest {
listOf( listOf(
seedSong(sourceId).copy(albumId = "al-0001"), seedSong(sourceId).copy(albumId = "al-0001"),
seedSong(sourceId).copy(id = "s2", albumId = "al-0002"), seedSong(sourceId).copy(id = "s2", albumId = "al-0002"),
seedSong(sourceId).copy(id = "s3", albumId = "al-0002", artistId = "ar2"),
seedSong(sourceId).copy(id = "s4", albumId = "al-0001", artistId = "ar2"),
), ),
) )
db.downloadDao().upsert(SongDownload(sourceId, "s1", DownloadStatus.Completed)) db.downloadDao().upsert(SongDownload(sourceId, "s4", DownloadStatus.Completed))
val before = repository.artistAlbums(sourceId, "ar1", downloaded = true).first() val otherOnAlbumCredit = repository.artistAlbums(sourceId, "ar1", downloaded = true).first()
assertEquals(listOf("al-0001"), before.albumCredits.map { it.id }) assertEquals(listOf("al-0001"), otherOnAlbumCredit.albumCredits.map { it.id })
assertEquals(emptyList<String>(), before.appearances.map { it.id }) assertEquals(emptyList<String>(), otherOnAlbumCredit.appearances.map { it.id })
db.downloadDao().upsert(SongDownload(sourceId, "s3", DownloadStatus.Completed))
val otherOnTrackCredit = repository.artistAlbums(sourceId, "ar1", downloaded = true).first()
assertEquals(listOf("al-0001"), otherOnTrackCredit.albumCredits.map { it.id })
assertEquals(emptyList<String>(), otherOnTrackCredit.appearances.map { it.id })
db.downloadDao().upsert(SongDownload(sourceId, "s2", DownloadStatus.Completed)) db.downloadDao().upsert(SongDownload(sourceId, "s2", DownloadStatus.Completed))
val after = repository.artistAlbums(sourceId, "ar1", downloaded = true).first() val creditedTrack = repository.artistAlbums(sourceId, "ar1", downloaded = true).first()
assertEquals(listOf("al-0001"), after.albumCredits.map { it.id }) assertEquals(listOf("al-0001"), creditedTrack.albumCredits.map { it.id })
assertEquals(listOf("al-0002"), after.appearances.map { it.id }) assertEquals(listOf("al-0002"), creditedTrack.appearances.map { it.id })
} }
private suspend fun awaitRefreshes( private suspend fun awaitRefreshes(