Makussu/subtracks
1
0
Fork 0
mirror of https://github.com/austinried/subtracks.git synced 2026-11-11 07:29:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

address review: keep one unbounded cover axis undefined instead of forcing a square

Browse Source
This commit is contained in:
austinried
2026-10-04 00:29:59 +00:00
parent 43f39300ce
commit 90171468cc
2 changed files with 34 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/test/kotlin/com/subtracks/ui/components/CoverArtRequestTest.kt
+12 -2
View File
@@ -1,7 +1,6 @@
package com.subtracks.ui.components
import android.content.Context
import androidx.compose.ui.unit.IntSize
import androidx.test.core.app.ApplicationProvider
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.subtracks.data.model.CoverArtRef
@@ -16,12 +15,23 @@ class CoverArtRequestTest {
val context = ApplicationProvider.getApplicationContext<Context>()
val ref = CoverArtRef(url = "http://example.test/art", cacheKey = "1:art:false")
val request = imageRequest(context, ref, crossfade = false, size = IntSize(600, 800))
val request = imageRequest(context, ref, crossfade = false, width = 600, height = 800)
assertEquals("1:art:false:600x800", request.memoryCacheKey)
assertEquals(ref.cacheKey, request.diskCacheKey)
}
@Test
fun oneUnboundedAxisIsNotForcedSquare() {
val context = ApplicationProvider.getApplicationContext<Context>()
val ref = CoverArtRef(url = "http://example.test/art", cacheKey = "1:art:false")
val request = imageRequest(context, ref, crossfade = false, width = 600)
assertEquals("1:art:false:600xu", request.memoryCacheKey)
assertEquals(ref.cacheKey, request.diskCacheKey)
}
@Test
fun unsizedRequestKeepsTheIdentityMemoryKey() {
val context = ApplicationProvider.getApplicationContext<Context>()