From b8f8297c9b8b75af4ea60892290d5e4c26d5ee3d Mon Sep 17 00:00:00 2001 From: austinried <4966622+austinried@users.noreply.github.com> Date: Fri, 25 Sep 2026 09:17:29 +0000 Subject: [PATCH] make disc headers read as section labels The header was the same size as the track title, so render it uppercase labelLarge with letter spacing to separate it from the tracks. Use the outlined FiberSmartRecord icon. --- .../com/subtracks/ui/library/AlbumDetailScreen.kt | 10 ++++++---- app/src/test/kotlin/com/subtracks/ui/AlbumDiscsTest.kt | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/app/src/main/kotlin/com/subtracks/ui/library/AlbumDetailScreen.kt b/app/src/main/kotlin/com/subtracks/ui/library/AlbumDetailScreen.kt index f3d76009..aa8c1bcf 100644 --- a/app/src/main/kotlin/com/subtracks/ui/library/AlbumDetailScreen.kt +++ b/app/src/main/kotlin/com/subtracks/ui/library/AlbumDetailScreen.kt @@ -7,7 +7,7 @@ import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.size import androidx.compose.foundation.layout.width import androidx.compose.material.icons.Icons -import androidx.compose.material.icons.rounded.FiberSmartRecord +import androidx.compose.material.icons.outlined.FiberSmartRecord import androidx.compose.material3.Icon import androidx.compose.material3.MaterialTheme import androidx.compose.material3.Text @@ -18,6 +18,7 @@ import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.text.font.FontWeight import androidx.compose.ui.unit.dp +import androidx.compose.ui.unit.sp import androidx.lifecycle.compose.collectAsStateWithLifecycle import com.subtracks.data.model.Album import com.subtracks.data.model.CoverArtRef @@ -151,16 +152,17 @@ private fun DiscHeader(text: String) { modifier = Modifier.padding(start = 8.dp, end = 16.dp, top = 20.dp, bottom = 4.dp), ) { Icon( - imageVector = Icons.Rounded.FiberSmartRecord, + imageVector = Icons.Outlined.FiberSmartRecord, contentDescription = null, tint = MaterialTheme.colorScheme.onSurfaceVariant, modifier = Modifier.size(20.dp), ) Spacer(Modifier.width(8.dp)) Text( - text = text, - style = MaterialTheme.typography.titleMedium, + text = text.uppercase(), + style = MaterialTheme.typography.labelLarge, fontWeight = FontWeight.SemiBold, + letterSpacing = 1.sp, color = MaterialTheme.colorScheme.onSurfaceVariant, ) } diff --git a/app/src/test/kotlin/com/subtracks/ui/AlbumDiscsTest.kt b/app/src/test/kotlin/com/subtracks/ui/AlbumDiscsTest.kt index 67db0381..34821551 100644 --- a/app/src/test/kotlin/com/subtracks/ui/AlbumDiscsTest.kt +++ b/app/src/test/kotlin/com/subtracks/ui/AlbumDiscsTest.kt @@ -111,7 +111,7 @@ class AlbumDiscsTest { composeRule.waitUntil(timeoutMillis = 5_000) { nodesWithText(songs.first().title) == 1 } } - private fun nodesWithText(text: String) = composeRule.onAllNodesWithText(text).fetchSemanticsNodes().size + private fun nodesWithText(text: String) = composeRule.onAllNodesWithText(text, ignoreCase = true).fetchSemanticsNodes().size private fun song( id: String,