Makussu/subtracks
1
0
Fork 0
mirror of https://github.com/austinried/subtracks.git synced 2026-11-11 15:29:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

db: pin the downloaded artist count access path in the plan test

Browse Source 
Assert the sourceId index as well as the in-memory sort for the downloaded
Artist album count order, and fold the top-level plan helper into plan().
This commit is contained in:
austinried
2026-11-03 01:03:45 +00:00
parent 18c24ca566
commit c165a6cc88
1 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/test/kotlin/com/subtracks/data/db/LibraryDaoTest.kt
+10 -13
View File
@@ -413,13 +413,15 @@ class LibraryDaoTest {
) )
for ((order, index) in orders) { for ((order, index) in orders) {
val plan = val plan =
topLevelPlan( plan(
"SELECT $ARTIST_COLUMNS_DOWNLOADED $ARTISTS_FILTER_DOWNLOADED " + "SELECT $ARTIST_COLUMNS_DOWNLOADED $ARTISTS_FILTER_DOWNLOADED " +
"ORDER BY $order LIMIT 20 OFFSET 0", "ORDER BY $order LIMIT 20 OFFSET 0",
topLevelOnly = true,
) )
if (order == ARTIST_ORDER_BY_ALBUM_COUNT || order == ARTIST_ORDER_BY_ALBUM_COUNT_REVERSED) { if (order == ARTIST_ORDER_BY_ALBUM_COUNT || order == ARTIST_ORDER_BY_ALBUM_COUNT_REVERSED) {
// The displayed count comes from song_downloads, so this order cannot use // The displayed count comes from song_downloads, so this order cannot use
// index_artists_albumCount; the hand-written statement sorted in memory too. // index_artists_albumCount; the hand-written statement sorted in memory too.
assertTrue("$order\n$plan", plan.contains("USING INDEX index_artists_sourceId"))
assertTrue("$order\n$plan", plan.contains("USE TEMP B-TREE FOR ORDER BY")) assertTrue("$order\n$plan", plan.contains("USE TEMP B-TREE FOR ORDER BY"))
} else { } else {
assertTrue("$order\n$plan", plan.contains("USING INDEX $index")) assertTrue("$order\n$plan", plan.contains("USING INDEX $index"))
@@ -446,9 +448,10 @@ class LibraryDaoTest {
assertFalse(defaultPlan, defaultPlan.contains("TEMP B-TREE")) assertFalse(defaultPlan, defaultPlan.contains("TEMP B-TREE"))
val downloadedPlan = val downloadedPlan =
topLevelPlan( plan(
"SELECT $PLAYLISTS_COLUMNS_DOWNLOADED $PLAYLISTS_FILTER_DOWNLOADED " + "SELECT $PLAYLISTS_COLUMNS_DOWNLOADED $PLAYLISTS_FILTER_DOWNLOADED " +
"ORDER BY $order LIMIT 20 OFFSET 0", "ORDER BY $order LIMIT 20 OFFSET 0",
topLevelOnly = true,
) )
assertTrue(downloadedPlan, downloadedPlan.contains("USING INDEX $index")) assertTrue(downloadedPlan, downloadedPlan.contains("USING INDEX $index"))
assertFalse(downloadedPlan, downloadedPlan.contains("USE TEMP B-TREE FOR ORDER BY")) assertFalse(downloadedPlan, downloadedPlan.contains("USE TEMP B-TREE FOR ORDER BY"))
@@ -1366,21 +1369,15 @@ class LibraryDaoTest {
assertFalse(plan, plan.contains("SCAN songs")) assertFalse(plan, plan.contains("SCAN songs"))
} }
private suspend fun plan(sql: String): String = private suspend fun plan(
db.useReaderConnection { connection -> sql: String,
connection.usePrepared("EXPLAIN QUERY PLAN $sql") { statement -> topLevelOnly: Boolean = false,
val details = mutableListOf<String>() ): String =
while (statement.step()) details += statement.getText(3)
details.joinToString("\n")
}
}
private suspend fun topLevelPlan(sql: String): String =
db.useReaderConnection { connection -> db.useReaderConnection { connection ->
connection.usePrepared("EXPLAIN QUERY PLAN $sql") { statement -> connection.usePrepared("EXPLAIN QUERY PLAN $sql") { statement ->
val details = mutableListOf<String>() val details = mutableListOf<String>()
while (statement.step()) { while (statement.step()) {
if (statement.getLong(1) == 0L) details += statement.getText(3) if (!topLevelOnly || statement.getLong(1) == 0L) details += statement.getText(3)
} }
details.joinToString("\n") details.joinToString("\n")
} }