From c53f1aef066d54f5d90d1a365857332a4c2b0648 Mon Sep 17 00:00:00 2001 From: austinried <4966622+austinried@users.noreply.github.com> Date: Wed, 21 Oct 2026 13:33:01 +0000 Subject: [PATCH] db: correct the paging filter comment The downloaded statements are no longer the old hand-written text, and RawQuery invalidation comes from observedEntities, not the filter text. --- app/src/main/kotlin/com/subtracks/data/db/LibraryPaging.kt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/src/main/kotlin/com/subtracks/data/db/LibraryPaging.kt b/app/src/main/kotlin/com/subtracks/data/db/LibraryPaging.kt index d1cd404f..8efa2c0b 100644 --- a/app/src/main/kotlin/com/subtracks/data/db/LibraryPaging.kt +++ b/app/src/main/kotlin/com/subtracks/data/db/LibraryPaging.kt @@ -7,9 +7,8 @@ import com.subtracks.data.prefs.ArtistSort import com.subtracks.data.prefs.PlaylistSort import com.subtracks.data.prefs.SortNameMode -// The default filters never mention song_downloads, so the paging sources used without the -// Downloaded filter are not invalidated by download writes (including progress updates). The -// downloaded variants are the same statements the hand-written queries used. +// The default filters intentionally omit song_downloads: the unfiltered lists do not need the +// join, and their paging sources must not invalidate on download progress updates. internal const val ALBUMS_FILTER = """ FROM albums WHERE sourceId = :sourceId AND (:starredFilter = 0 OR (:starredFilter = 1 AND starred IS NOT NULL) OR (:starredFilter = 2 AND starred IS NULL))