Makussu/subtracks
1
0
Fork 0
mirror of https://github.com/austinried/subtracks.git synced 2026-11-11 07:29:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

preload the neighbouring library tab

Browse Source 
beyondViewportPageCount = 1 keeps the next tab's paging flow subscribed, so Artists
replays cached data instead of showing a spinner the first time it is opened.
This commit is contained in:
austinried
2026-10-04 00:30:00 +00:00
parent 9f250d49f2
commit c7bab22dc5
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/kotlin/com/subtracks/ui/library/LibraryScreen.kt
+1
View File
@@ -335,6 +335,7 @@ fun LibraryScreen(
HorizontalPager( HorizontalPager(
state = pagerState, state = pagerState,
modifier = Modifier.fillMaxSize(), modifier = Modifier.fillMaxSize(),
beyondViewportPageCount = 1,
) { page -> ) { page ->
val pageTab = LibraryTab.entries[page] val pageTab = LibraryTab.entries[page]
val resetKey = resetKeys[pageTab] val resetKey = resetKeys[pageTab]
app/src/test/kotlin/com/subtracks/ui/LibraryScreenTest.kt
+3 -5
View File
@@ -32,7 +32,6 @@ import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.flow import kotlinx.coroutines.flow.flow
import kotlinx.coroutines.flow.flowOf import kotlinx.coroutines.flow.flowOf
import org.junit.Assert.assertEquals import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue import org.junit.Assert.assertTrue
import org.junit.Rule import org.junit.Rule
import org.junit.Test import org.junit.Test
@@ -112,7 +111,7 @@ class LibraryScreenTest {
} }
@Test @Test
fun onlyTheVisibleTabCollectsItsPagingFlow() { fun theVisibleTabAndItsNeighbourCollectTheirPagingFlows() {
val collected = CopyOnWriteArrayList<String>() val collected = CopyOnWriteArrayList<String>()
val albums = val albums =
flow<PagingData<Album>> { flow<PagingData<Album>> {
@@ -147,10 +146,10 @@ class LibraryScreenTest {
} }
} }
composeRule.waitUntil(timeoutMillis = 5_000) { collected.isNotEmpty() } composeRule.waitUntil(timeoutMillis = 5_000) { collected.contains("artists") }
composeRule.waitForIdle() composeRule.waitForIdle()
assertEquals(listOf("albums"), collected.toList()) assertEquals(listOf("albums", "artists"), collected.toList())
} }
@Test @Test
@@ -204,7 +203,6 @@ class LibraryScreenTest {
assertTrue("returning to a tab should render its content", collected.contains("albums")) assertTrue("returning to a tab should render its content", collected.contains("albums"))
assertTrue("the tab that was shown should collect its flow", collected.contains("artists")) assertTrue("the tab that was shown should collect its flow", collected.contains("artists"))
assertFalse("inactive tabs should not collect their flows", collected.contains("playlists"))
} }
@Test @Test