Makussu/subtracks
1
0
Fork 0
mirror of https://github.com/austinried/subtracks.git synced 2026-11-11 15:29:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

ui: separate info labels from their values

Browse Source
This commit is contained in:
austinried
2026-10-20 14:58:52 +00:00
parent c56a6d4f83
commit fbd4c0c4fe
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/kotlin/com/subtracks/ui/components/LibraryInfoDialog.kt
+4 -1
View File
@@ -5,6 +5,7 @@ import android.text.format.DateUtils
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width import androidx.compose.foundation.layout.width
@@ -101,6 +102,7 @@ internal fun InfoRow(
color = MaterialTheme.colorScheme.primary, color = MaterialTheme.colorScheme.primary,
modifier = Modifier.width(INFO_LABEL_WIDTH), modifier = Modifier.width(INFO_LABEL_WIDTH),
) )
Spacer(Modifier.width(INFO_LABEL_GAP))
Text( Text(
text = value, text = value,
style = MaterialTheme.typography.bodyMedium, style = MaterialTheme.typography.bodyMedium,
@@ -126,4 +128,5 @@ private fun formatDate(
DateUtils.FORMAT_SHOW_DATE or DateUtils.FORMAT_SHOW_YEAR, DateUtils.FORMAT_SHOW_DATE or DateUtils.FORMAT_SHOW_YEAR,
) )
private val INFO_LABEL_WIDTH = 96.dp private val INFO_LABEL_WIDTH = 100.dp
private val INFO_LABEL_GAP = 12.dp
app/src/test/kotlin/com/subtracks/ui/components/LibraryInfoDialogTest.kt
+5
View File
@@ -9,6 +9,7 @@ import com.subtracks.data.model.Album
import com.subtracks.data.model.Artist import com.subtracks.data.model.Artist
import com.subtracks.data.model.ArtistRef import com.subtracks.data.model.ArtistRef
import com.subtracks.ui.theme.SubtracksTheme import com.subtracks.ui.theme.SubtracksTheme
import org.junit.Assert.assertTrue
import org.junit.Rule import org.junit.Rule
import org.junit.Test import org.junit.Test
import org.junit.runner.RunWith import org.junit.runner.RunWith
@@ -52,6 +53,10 @@ class LibraryInfoDialogTest {
composeRule.onNodeWithText("Album, The").assertIsDisplayed() composeRule.onNodeWithText("Album, The").assertIsDisplayed()
composeRule.onNodeWithText("A, The").assertIsDisplayed() composeRule.onNodeWithText("A, The").assertIsDisplayed()
composeRule.onNodeWithText("1999").assertIsDisplayed() composeRule.onNodeWithText("1999").assertIsDisplayed()
val label = composeRule.onNodeWithText("Album artist sort").fetchSemanticsNode().boundsInRoot
val value = composeRule.onNodeWithText("A, The").fetchSemanticsNode().boundsInRoot
assertTrue("the value must be separated from its label", value.left > label.right)
} }
@Test @Test