remove todo

create log file if it doesn't exist first

lib/app/lists.dart

@@ -4,6 +4,7 @@ import 'package:infinite_scroll_pagination/infinite_scroll_pagination.dart';
 
 import '../services/sync_service.dart';
 import 'items.dart';
+import 'snackbars.dart';
 
 class PagedListQueryView<T> extends HookConsumerWidget {
   final PagingController<int, T> pagingController;
@@ -122,7 +123,13 @@ class SyncAllRefresh extends HookConsumerWidget {
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     return RefreshIndicator(
-      onRefresh: () => ref.read(syncServiceProvider.notifier).syncAll(),
+      onRefresh: () async {
+        try {
+          await ref.read(syncServiceProvider.notifier).syncAll();
+        } catch (e) {
+          showErrorSnackbar(context, e.toString());
+        }
+      },
       child: child,
     );
   }

lib/app/pages/source_page.dart

@@ -12,6 +12,7 @@ import '../../log.dart';
 import '../../models/settings.dart';
 import '../../services/settings_service.dart';
 import '../items.dart';
+import '../snackbars.dart';
 
 class SourcePage extends HookConsumerWidget {
   final int? id;
@@ -163,7 +164,7 @@ class SourcePage extends HookConsumerWidget {
                               );
                         }
                       } catch (e, st) {
-                        // TOOD: toast the error or whatever
+                        showErrorSnackbar(context, e.toString());
                         log.severe('Saving source', e, st);
                         error = true;
                       } finally {

lib/app/snackbars.dart

@@ -0,0 +1,14 @@
+import 'package:flutter/material.dart';
+
+void showErrorSnackbar(BuildContext context, String message) {
+  final colors = Theme.of(context).colorScheme;
+
+  ScaffoldMessenger.of(context).showSnackBar(SnackBar(
+    content: Text(message, style: TextStyle(color: colors.onErrorContainer)),
+    backgroundColor: colors.errorContainer,
+    showCloseIcon: true,
+    closeIconColor: colors.onErrorContainer,
+    behavior: SnackBarBehavior.floating,
+    duration: const Duration(seconds: 10),
+  ));
+}

lib/http/client.dart

@@ -15,26 +15,17 @@ class SubtracksHttpClient extends BaseClient {
   @override
   Future<StreamedResponse> send(BaseRequest request) {
     request.headers.addAll(subtracksHeaders);
-    log.info('${request.method} ${_redactUri(request.url)}');
-    return request.send();
+    log.info('${request.method} ${request.url}');
+
+    try {
+      return request.send();
+    } catch (e, st) {
+      log.severe('HTTP client: ${request.method} ${request.url}', e, st);
+      rethrow;
+    }
   }
 }
 
-String _redactUri(Uri uri) {
-  var redacted = uri.toString();
-  redacted = _redactParam(redacted, 'u');
-  redacted = _redactParam(redacted, 'p');
-  redacted = _redactParam(redacted, 's');
-  redacted = _redactParam(redacted, 't');
-
-  return redacted.toString();
-}
-
-RegExp _queryReplace(String key) => RegExp('$key=([^&|\\n|\\t\\s]+)');
-
-String _redactParam(String url, String key) =>
-    url.replaceFirst(_queryReplace(key), '$key=REDACTED');
-
 @Riverpod(keepAlive: true)
 BaseClient httpClient(HttpClientRef ref) {
   return SubtracksHttpClient();

lib/log.dart

@@ -88,6 +88,7 @@ String _format(
   bool color = false,
   bool time = true,
   bool level = true,
+  bool redact = true,
 }) {
   var message = '';
   if (time) message += '${event.time.toIso8601String()} ';
@@ -107,6 +108,11 @@ String _format(
   if (event.error != null) {
     message += '\n${event.error}';
   }
+
+  if (redact) {
+    message = _redactUrl(message);
+  }
+
   if (event.stackTrace != null) {
     message += '\n${event.stackTrace}';
   }
@@ -116,17 +122,24 @@ String _format(
       : message;
 }
 
-Future<void> _printFile(String event, String dir) async {
-  final now = DateTime.now();
-  final file = File(p.join(dir, '${now.year}-${now.month}-${now.day}.txt'));
-
-  if (!event.endsWith('\n')) {
-    event += '\n';
+String _redactUrl(String message) {
+  if (!_queryReplace('u').hasMatch(message)) {
+    return message;
   }
 
-  await file.writeAsString(event, mode: FileMode.writeOnlyAppend, flush: true);
+  message = _redactParam(message, 'u');
+  message = _redactParam(message, 'p');
+  message = _redactParam(message, 's');
+  message = _redactParam(message, 't');
+
+  return message;
 }
 
+RegExp _queryReplace(String key) => RegExp('$key=([^&|\\n|\\t\\s]+)');
+
+String _redactParam(String url, String key) =>
+    url.replaceAll(_queryReplace(key), '$key=REDACTED');
+
 Future<Directory> logDirectory() async {
   return Directory(
     p.join((await getApplicationDocumentsDirectory()).path, 'logs'),
@@ -141,11 +154,43 @@ Future<List<File>> logFiles() async {
     );
 }
 
+File _currentLogFile(String logDir) {
+  final now = DateTime.now();
+  return File(p.join(logDir, '${now.year}-${now.month}-${now.day}.txt'));
+}
+
+Future<void> _printFile(String event, String logDir) async {
+  final file = _currentLogFile(logDir);
+
+  if (!event.endsWith('\n')) {
+    event += '\n';
+  }
+
+  await file.writeAsString(event, mode: FileMode.writeOnlyAppend, flush: true);
+}
+
+void _printDebug(LogRecord event) {
+  // ignore: avoid_print
+  print(_format(event, color: true, time: false, level: false, redact: false));
+}
+
+Future<void> _printRelease(LogRecord event, String logDir) async {
+  await _printFile(
+    _format(event, color: false, time: true, level: true, redact: true),
+    logDir,
+  );
+}
+
 final log = Logger('default');
 
 Future<void> initLogging() async {
   final dir = (await logDirectory())..create();
 
+  final file = _currentLogFile(dir.path);
+  if (!(await file.exists())) {
+    await file.create();
+  }
+
   final files = await logFiles();
   if (files.length > 7) {
     for (var file in files.slice(7)) {
@@ -156,14 +201,9 @@ Future<void> initLogging() async {
   Logger.root.level = kDebugMode ? Level.ALL : Level.INFO;
   Logger.root.onRecord.asyncMap((event) async {
     if (kDebugMode) {
-      print(_format(event, color: true, time: false, level: false));
+      _printDebug(event);
     } else {
-      await _printFile(
-        _format(event, color: false, time: true, level: true),
-        dir.path,
-      );
+      await _printRelease(event, dir.path);
     }
   }).listen((_) {}, cancelOnError: false);
-
-  log.info('start');
 }

lib/services/audio_service.dart

@@ -95,36 +95,36 @@ class AudioControl extends BaseAudioHandler with QueueHandler, SeekHandler {
   int get _sourceId => _ref.read(sourceIdProvider);
 
   AudioControl(this._player, this._ref) {
-    _player.playbackEventStream.listen(
-      (PlaybackEvent event) {
-        final playing = _player.playing;
-        playbackState.add(playbackState.value.copyWith(
-          controls: [
-            MediaControl.skipToPrevious,
-            if (playing) MediaControl.pause else MediaControl.play,
-            MediaControl.stop,
-            MediaControl.skipToNext,
-          ],
-          systemActions: const {
-            MediaAction.seek,
-          },
-          androidCompactActionIndices: const [0, 1, 3],
-          processingState: const {
-            ProcessingState.idle: AudioProcessingState.idle,
-            ProcessingState.loading: AudioProcessingState.loading,
-            ProcessingState.buffering: AudioProcessingState.buffering,
-            ProcessingState.ready: AudioProcessingState.ready,
-            ProcessingState.completed: AudioProcessingState.completed,
-          }[_player.processingState]!,
-          playing: playing,
-          updatePosition: _player.position,
-          bufferedPosition: _player.bufferedPosition,
-          queueIndex: event.currentIndex,
-        ));
-      },
-      onError: (e, st) => log.warning('Audio playback error', e, st),
-      cancelOnError: false,
-    );
+    _player.playbackEventStream.listen((PlaybackEvent event) {
+      final playing = _player.playing;
+      playbackState.add(playbackState.value.copyWith(
+        controls: [
+          MediaControl.skipToPrevious,
+          if (playing) MediaControl.pause else MediaControl.play,
+          MediaControl.stop,
+          MediaControl.skipToNext,
+        ],
+        systemActions: const {
+          MediaAction.seek,
+        },
+        androidCompactActionIndices: const [0, 1, 3],
+        processingState: const {
+          ProcessingState.idle: AudioProcessingState.idle,
+          ProcessingState.loading: AudioProcessingState.loading,
+          ProcessingState.buffering: AudioProcessingState.buffering,
+          ProcessingState.ready: AudioProcessingState.ready,
+          ProcessingState.completed: AudioProcessingState.completed,
+        }[_player.processingState]!,
+        playing: playing,
+        updatePosition: _player.position,
+        bufferedPosition: _player.bufferedPosition,
+        queueIndex: event.currentIndex,
+      ));
+    });
+
+    _player.playbackEventStream.doOnError((e, st) async {
+      log.warning('playbackEventStream', e, st);
+    });
 
     shuffleIndicies.listen((value) {
       playbackState.add(playbackState.value.copyWith(

lib/services/settings_service.dart

@@ -53,6 +53,8 @@ class SettingsService extends _$SettingsService {
       ref.read(httpClientProvider),
     );
 
+    await client.test();
+
     final features = IList([
       if (await client.testFeature(SubsonicFeature.emptyQuerySearch))
         SubsonicFeature.emptyQuerySearch,
@@ -66,6 +68,10 @@ class SettingsService extends _$SettingsService {
   }
 
   Future<void> updateSource(SubsonicSettings source) async {
+    final client = SubsonicClient(source, ref.read(httpClientProvider));
+
+    await client.test();
+
     await _db.updateSource(source);
     await init();
   }

lib/sources/music_source.dart

@@ -1,6 +1,8 @@
 import 'package:hooks_riverpod/hooks_riverpod.dart';
+import 'package:rxdart/rxdart.dart';
 
 import '../database/database.dart';
+import '../log.dart';
 import '../state/settings.dart';
 
 abstract class BaseMusicSource {
@@ -40,25 +42,33 @@ class MusicSource implements BaseMusicSource {
   @override
   Stream<Iterable<AlbumsCompanion>> allAlbums() {
     _testOnline();
-    return _source.allAlbums();
+    return _source
+        .allAlbums()
+        .doOnError((e, st) => log.severe('allAlbums', e, st));
   }
 
   @override
   Stream<Iterable<ArtistsCompanion>> allArtists() {
     _testOnline();
-    return _source.allArtists();
+    return _source
+        .allArtists()
+        .doOnError((e, st) => log.severe('allArtists', e, st));
   }
 
   @override
   Stream<Iterable<PlaylistWithSongsCompanion>> allPlaylists() {
     _testOnline();
-    return _source.allPlaylists();
+    return _source
+        .allPlaylists()
+        .doOnError((e, st) => log.severe('allPlaylists', e, st));
   }
 
   @override
   Stream<Iterable<SongsCompanion>> allSongs() {
     _testOnline();
-    return _source.allSongs();
+    return _source
+        .allSongs()
+        .doOnError((e, st) => log.severe('allSongs', e, st));
   }
 
   @override

lib/sources/subsonic/client.dart

@@ -98,6 +98,8 @@ class SubsonicClient {
     return subsonicResponse;
   }
 
+  Future<void> test() => get('ping');
+
   Future<bool> testFeature(SubsonicFeature feature) async {
     switch (feature) {
       case SubsonicFeature.emptyQuerySearch: