don't pass all ids as params

instead, only pass ids to delete and chunk those by the param limit

TODO.md

@@ -14,14 +14,10 @@
 - [ ] Library list display modes
 - [ ] Search
   - [ ] Individual "more" results pages
-- [ ] Radio modes
-  - [ ] Artist
 - [ ] Now playing gestures
   - [ ] Swipe bar/album to skip
   - [ ] Double-tap to seek forward/back (bar only)
 - [ ] Settings
-  - [ ] Sources
-    - [ ] Use plaintext password
   - [ ] Music
     - [ ] Scrobble
   - [ ] Downloads

lib/app/pages/artist_page.dart

@@ -1,13 +1,19 @@
 import 'dart:math';
 
 import 'package:auto_route/auto_route.dart';
+import 'package:fast_immutable_collections/fast_immutable_collections.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_staggered_grid_view/flutter_staggered_grid_view.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 
+import '../../database/database.dart';
+import '../../models/query.dart';
+import '../../models/support.dart';
+import '../../services/audio_service.dart';
 import '../../state/music.dart';
 import '../../state/settings.dart';
 import '../app_router.dart';
+import '../buttons.dart';
 import '../images.dart';
 import '../items.dart';
 
@@ -27,6 +33,26 @@ class ArtistPage extends HookConsumerWidget {
     final albums = ref.watch(albumsByArtistIdProvider(id));
 
     return Scaffold(
+      floatingActionButton: RadioPlayFab(
+        onPressed: () => artist.hasValue
+            ? ref.read(audioControlProvider).playRadio(
+                  context: QueueContextType.artist,
+                  contextId: artist.valueOrNull!.id,
+                  query: ListQuery(
+                    filters: IList([
+                      FilterWith.equals(
+                        column: 'artist_id',
+                        value: artist.valueOrNull!.id,
+                      )
+                    ]),
+                  ),
+                  getSongs: (query) => ref
+                      .read(databaseProvider)
+                      .songsList(ref.read(sourceIdProvider), query)
+                      .get(),
+                )
+            : null,
+      ),
       body: CustomScrollView(
         slivers: [
           SliverToBoxAdapter(

lib/app/pages/source_page.dart

@@ -41,6 +41,7 @@ class SourcePage extends HookConsumerWidget {
       label: l.settingsServersFieldsAddress,
       initialValue: source?.address.toString(),
       keyboardType: TextInputType.url,
+      autofillHints: const [AutofillHints.url],
       required: true,
       validator: (value, label) {
         if (Uri.tryParse(value!) == null) {
@@ -52,12 +53,14 @@ class SourcePage extends HookConsumerWidget {
     final username = LabeledTextField(
       label: l.settingsServersFieldsUsername,
       initialValue: source?.username,
+      autofillHints: const [AutofillHints.username],
       required: true,
     );
     final password = LabeledTextField(
       label: l.settingsServersFieldsPassword,
       initialValue: source?.password,
       obscureText: true,
+      autofillHints: const [AutofillHints.password],
       required: true,
     );
 
@@ -175,26 +178,28 @@ class SourcePage extends HookConsumerWidget {
         ),
         body: Form(
           key: form,
-          child: ListView(
+          child: AutofillGroup(
-            children: [
+            child: ListView(
-              const SizedBox(height: 96 - kToolbarHeight),
+              children: [
-              Padding(
+                const SizedBox(height: 96 - kToolbarHeight),
-                padding: const EdgeInsets.symmetric(horizontal: 16),
+                Padding(
-                child: Text(
+                  padding: const EdgeInsets.symmetric(horizontal: 16),
-                  source == null
+                  child: Text(
-                      ? l.settingsServersActionsAdd
+                    source == null
-                      : l.settingsServersActionsEdit,
+                        ? l.settingsServersActionsAdd
-                  style: theme.textTheme.displaySmall,
+                        : l.settingsServersActionsEdit,
+                    style: theme.textTheme.displaySmall,
+                  ),
                 ),
-              ),
+                name,
-              name,
+                address,
-              address,
+                username,
-              username,
+                password,
-              password,
+                const SizedBox(height: 24),
-              const SizedBox(height: 24),
+                forcePlaintextSwitch,
-              forcePlaintextSwitch,
+                const FabPadding(),
-              const FabPadding(),
+              ],
-            ],
+            ),
           ),
         ),
       ),
@@ -208,6 +213,7 @@ class LabeledTextField extends HookConsumerWidget {
   final bool obscureText;
   final bool required;
   final TextInputType? keyboardType;
+  final Iterable<String>? autofillHints;
   final String? Function(String? value, String label)? validator;
 
   // ignore: prefer_const_constructors_in_immutables
@@ -218,6 +224,7 @@ class LabeledTextField extends HookConsumerWidget {
     this.obscureText = false,
     this.keyboardType,
     this.validator,
+    this.autofillHints,
     this.required = false,
   });
 
@@ -249,6 +256,7 @@ class LabeledTextField extends HookConsumerWidget {
             controller: _controller,
             obscureText: obscureText,
             keyboardType: keyboardType,
+            autofillHints: autofillHints,
             validator: (value) {
               String? error;
 

lib/database/database.dart

@@ -17,6 +17,10 @@ import 'converters.dart';
 
 part 'database.g.dart';
 
+// don't exceed SQLITE_MAX_VARIABLE_NUMBER (32766 for version >= 3.32.0)
+// https://www.sqlite.org/limits.html
+const kSqliteMaxVariableNumber = 32766;
+
 @DriftDatabase(include: {'tables.drift'})
 class SubtracksDatabase extends _$SubtracksDatabase {
   SubtracksDatabase() : super(_openConnection());
@@ -169,12 +173,27 @@ class SubtracksDatabase extends _$SubtracksDatabase {
     });
   }
 
-  Future<void> deleteArtistsNotIn(int sourceId, Iterable<String> ids) async {
+  Future<void> deleteArtistsNotIn(int sourceId, Set<String> ids) {
-    await (delete(artists)
+    return transaction(() async {
-          ..where(
+      final allIds = (await (selectOnly(artists)
-            (tbl) => tbl.sourceId.equals(sourceId) & tbl.id.isNotIn(ids),
+                ..addColumns([artists.id])
-          ))
+                ..where(artists.sourceId.equals(sourceId)))
-        .go();
+              .map((row) => row.read(artists.id))
+              .get())
+          .whereNotNull()
+          .toSet();
+      final downloadIds = (await artistIdsWithDownloadStatus(sourceId).get())
+          .whereNotNull()
+          .toSet();
+
+      final diff = allIds.difference(downloadIds).difference(ids);
+      for (var slice in diff.slices(kSqliteMaxVariableNumber)) {
+        await (delete(artists)
+              ..where(
+                  (tbl) => tbl.sourceId.equals(sourceId) & tbl.id.isIn(slice)))
+            .go();
+      }
+    });
   }
 
   Future<void> saveAlbums(Iterable<AlbumsCompanion> albums) async {
@@ -183,15 +202,27 @@ class SubtracksDatabase extends _$SubtracksDatabase {
     });
   }
 
-  Future<void> deleteAlbumsNotIn(int sourceId, Iterable<String> ids) async {
+  Future<void> deleteAlbumsNotIn(int sourceId, Set<String> ids) {
-    final alsoKeep = (await albumIdsWithDownloaded(sourceId).get()).toSet();
+    return transaction(() async {
+      final allIds = (await (selectOnly(albums)
+                ..addColumns([albums.id])
+                ..where(albums.sourceId.equals(sourceId)))
+              .map((row) => row.read(albums.id))
+              .get())
+          .whereNotNull()
+          .toSet();
+      final downloadIds = (await albumIdsWithDownloadStatus(sourceId).get())
+          .whereNotNull()
+          .toSet();
 
-    ids = ids.toList()..addAll(alsoKeep);
+      final diff = allIds.difference(downloadIds).difference(ids);
-    await (delete(albums)
+      for (var slice in diff.slices(kSqliteMaxVariableNumber)) {
-          ..where(
+        await (delete(albums)
-            (tbl) => tbl.sourceId.equals(sourceId) & tbl.id.isNotIn(ids),
+              ..where(
-          ))
+                  (tbl) => tbl.sourceId.equals(sourceId) & tbl.id.isIn(slice)))
-        .go();
+            .go();
+      }
+    });
   }
 
   Future<void> savePlaylists(
@@ -215,18 +246,31 @@ class SubtracksDatabase extends _$SubtracksDatabase {
     });
   }
 
-  Future<void> deletePlaylistsNotIn(int sourceId, Iterable<String> ids) async {
+  Future<void> deletePlaylistsNotIn(int sourceId, Set<String> ids) {
-    await (delete(playlists)
+    return transaction(() async {
-          ..where(
+      final allIds = (await (selectOnly(playlists)
-            (tbl) => tbl.sourceId.equals(sourceId) & tbl.id.isNotIn(ids),
+                ..addColumns([playlists.id])
-          ))
+                ..where(playlists.sourceId.equals(sourceId)))
-        .go();
+              .map((row) => row.read(playlists.id))
-    await (delete(playlistSongs)
+              .get())
-          ..where(
+          .whereNotNull()
-            (tbl) =>
+          .toSet();
-                tbl.sourceId.equals(sourceId) & tbl.playlistId.isNotIn(ids),
+      final downloadIds = (await playlistIdsWithDownloadStatus(sourceId).get())
-          ))
+          .whereNotNull()
-        .go();
+          .toSet();
+
+      final diff = allIds.difference(downloadIds).difference(ids);
+      for (var slice in diff.slices(kSqliteMaxVariableNumber)) {
+        await (delete(playlists)
+              ..where(
+                  (tbl) => tbl.sourceId.equals(sourceId) & tbl.id.isIn(slice)))
+            .go();
+        await (delete(playlistSongs)
+              ..where((tbl) =>
+                  tbl.sourceId.equals(sourceId) & tbl.playlistId.isIn(slice)))
+            .go();
+      }
+    });
   }
 
   Future<void> savePlaylistSongs(
@@ -250,29 +294,33 @@ class SubtracksDatabase extends _$SubtracksDatabase {
     });
   }
 
-  Future<void> deleteSongsNotIn(int sourceId, Iterable<String> ids) async {
+  Future<void> deleteSongsNotIn(int sourceId, Set<String> ids) {
-    await (delete(songs)
+    return transaction(() async {
-          ..where(
+      final allIds = (await (selectOnly(songs)
-            (tbl) =>
+                ..addColumns([songs.id])
-                tbl.sourceId.equals(sourceId) &
+                ..where(
-                tbl.id.isNotIn(ids) &
+                  songs.sourceId.equals(sourceId) &
-                tbl.downloadFilePath.isNull() &
+                      songs.downloadFilePath.isNull() &
-                tbl.downloadTaskId.isNull(),
+                      songs.downloadTaskId.isNull(),
-          ))
+                ))
-        .go();
+              .map((row) => row.read(songs.id))
-    final remainingIds = (await (selectOnly(songs)
+              .get())
-              ..addColumns([songs.id])
+          .whereNotNull()
-              ..where(songs.sourceId.equals(sourceId)))
+          .toSet();
-            .map((row) => row.read(songs.id))
+
-            .get())
+      final diff = allIds.difference(ids);
-        .whereNotNull();
+      for (var slice in diff.slices(kSqliteMaxVariableNumber)) {
-    await (delete(playlistSongs)
+        await (delete(songs)
-          ..where(
+              ..where(
-            (tbl) =>
+                  (tbl) => tbl.sourceId.equals(sourceId) & tbl.id.isIn(slice)))
-                tbl.sourceId.equals(sourceId) &
+            .go();
-                tbl.songId.isNotIn(remainingIds),
+        await (delete(playlistSongs)
-          ))
+              ..where(
-        .go();
+                (tbl) => tbl.sourceId.equals(sourceId) & tbl.songId.isIn(slice),
+              ))
+            .go();
+      }
+    });
   }
 
   Selectable<LastBottomNavStateData> getLastBottomNavState() {

lib/database/database.g.dart

@@ -4596,7 +4596,7 @@ abstract class _$SubtracksDatabase extends GeneratedDatabase {
         ));
   }
 
-  Selectable<String> albumIdsWithDownloaded(int sourceId) {
+  Selectable<String> albumIdsWithDownloadStatus(int sourceId) {
     return customSelect(
         'SELECT albums.id FROM albums JOIN songs ON songs.source_id = albums.source_id AND songs.album_id = albums.id WHERE albums.source_id = ?1 AND(songs.download_file_path IS NOT NULL OR songs.download_task_id IS NOT NULL)GROUP BY albums.id',
         variables: [
@@ -4608,6 +4608,32 @@ abstract class _$SubtracksDatabase extends GeneratedDatabase {
         }).map((QueryRow row) => row.read<String>('id'));
   }
 
+  Selectable<String> artistIdsWithDownloadStatus(int sourceId) {
+    return customSelect(
+        'SELECT artists.id FROM artists LEFT JOIN albums ON artists.source_id = albums.source_id AND artists.id = albums.artist_id LEFT JOIN songs ON albums.source_id = songs.source_id AND albums.id = songs.album_id WHERE artists.source_id = ?1 AND(songs.download_file_path IS NOT NULL OR songs.download_task_id IS NOT NULL)GROUP BY artists.id',
+        variables: [
+          Variable<int>(sourceId)
+        ],
+        readsFrom: {
+          artists,
+          albums,
+          songs,
+        }).map((QueryRow row) => row.read<String>('id'));
+  }
+
+  Selectable<String> playlistIdsWithDownloadStatus(int sourceId) {
+    return customSelect(
+        'SELECT playlists.id FROM playlists LEFT JOIN playlist_songs ON playlist_songs.source_id = playlists.source_id AND playlist_songs.playlist_id = playlists.id LEFT JOIN songs ON playlist_songs.source_id = songs.source_id AND playlist_songs.song_id = songs.id WHERE playlists.source_id = ?1 AND(songs.download_file_path IS NOT NULL OR songs.download_task_id IS NOT NULL)GROUP BY playlists.id',
+        variables: [
+          Variable<int>(sourceId)
+        ],
+        readsFrom: {
+          playlists,
+          playlistSongs,
+          songs,
+        }).map((QueryRow row) => row.read<String>('id'));
+  }
+
   Selectable<int> searchArtists(String query, int limit, int offset) {
     return customSelect(
         'SELECT "rowid" FROM artists_fts WHERE artists_fts MATCH ?1 ORDER BY rank LIMIT ?2 OFFSET ?3',

lib/database/tables.drift

@@ -244,7 +244,7 @@ allSubsonicSources WITH SubsonicSettings:
   FROM sources
   JOIN subsonic_sources ON subsonic_sources.source_id = sources.id;
 
-albumIdsWithDownloaded:
+albumIdsWithDownloadStatus:
   SELECT albums.id
   FROM albums
   JOIN songs on songs.source_id = albums.source_id AND songs.album_id = albums.id
@@ -253,6 +253,26 @@ albumIdsWithDownloaded:
     AND (songs.download_file_path IS NOT NULL OR songs.download_task_id IS NOT NULL)
   GROUP BY albums.id;
 
+artistIdsWithDownloadStatus:
+  SELECT artists.id
+  FROM artists
+  LEFT JOIN albums ON artists.source_id = albums.source_id AND artists.id = albums.artist_id
+  LEFT JOIN songs ON albums.source_id = songs.source_id AND albums.id = songs.album_id
+  WHERE
+    artists.source_id = :source_id
+    AND (songs.download_file_path IS NOT NULL OR songs.download_task_id IS NOT NULL)
+  GROUP BY artists.id;
+
+playlistIdsWithDownloadStatus:
+  SELECT playlists.id
+  FROM playlists
+  LEFT JOIN playlist_songs ON playlist_songs.source_id = playlists.source_id AND playlist_songs.playlist_id = playlists.id
+  LEFT JOIN songs ON playlist_songs.source_id = songs.source_id AND playlist_songs.song_id = songs.id
+  WHERE 
+    playlists.source_id = :source_id
+    AND (songs.download_file_path IS NOT NULL OR songs.download_task_id IS NOT NULL)
+  GROUP BY playlists.id;
+
 searchArtists:
   SELECT rowid
   FROM artists_fts

lib/models/support.dart

@@ -68,7 +68,8 @@ enum QueueContextType {
   album('album'),
   playlist('playlist'),
   library('library'),
-  genre('genre');
+  genre('genre'),
+  artist('artist');
 
   const QueueContextType(this.value);
   final String value;

lib/models/support.g.dart

@@ -28,6 +28,7 @@ const _$QueueContextTypeEnumMap = {
   QueueContextType.playlist: 'playlist',
   QueueContextType.library: 'library',
   QueueContextType.genre: 'genre',
+  QueueContextType.artist: 'artist',
 };
 
 _$_MediaItemData _$$_MediaItemDataFromJson(Map<String, dynamic> json) =>

lib/services/download_service.dart

@@ -214,7 +214,7 @@ class DownloadService extends _$DownloadService {
   Future<void> deleteAll(int sourceId) async {
     final db = ref.read(databaseProvider);
 
-    final albumIds = await db.albumIdsWithDownloaded(sourceId).get();
+    final albumIds = await db.albumIdsWithDownloadStatus(sourceId).get();
     for (var id in albumIds) {
       await deleteAlbum(await (db.albumById(sourceId, id)).getSingle());
     }

lib/services/download_service.g.dart

@@ -6,7 +6,7 @@ part of 'download_service.dart';
 // RiverpodGenerator
 // **************************************************************************
 
-String _$downloadServiceHash() => r'92e963b5c070f4d1edb0cd81899b16393c2b9a70';
+String _$downloadServiceHash() => r'c72c49f980e307f3013467e76b6564d14a34a736';
 
 /// See also [DownloadService].
 @ProviderFor(DownloadService)

lib/services/sync_service.dart

@@ -31,7 +31,7 @@ class SyncService extends _$SyncService {
     final source = ref.read(musicSourceProvider);
     final db = ref.read(databaseProvider);
 
-    final ids = <String>[];
+    final ids = <String>{};
     await for (var artists in source.allArtists()) {
       ids.addAll(artists.map((e) => e.id.value));
       await db.saveArtists(artists);
@@ -44,7 +44,7 @@ class SyncService extends _$SyncService {
     final source = ref.read(musicSourceProvider);
     final db = ref.read(databaseProvider);
 
-    final ids = <String>[];
+    final ids = <String>{};
     await for (var albums in source.allAlbums()) {
       ids.addAll(albums.map((e) => e.id.value));
       await db.saveAlbums(albums);
@@ -57,7 +57,7 @@ class SyncService extends _$SyncService {
     final source = ref.read(musicSourceProvider);
     final db = ref.read(databaseProvider);
 
-    final ids = <String>[];
+    final ids = <String>{};
     await for (var playlists in source.allPlaylists()) {
       ids.addAll(playlists.map((e) => e.playist.id.value));
       await db.savePlaylists(playlists);
@@ -70,7 +70,7 @@ class SyncService extends _$SyncService {
     final source = ref.read(musicSourceProvider);
     final db = ref.read(databaseProvider);
 
-    final ids = <String>[];
+    final ids = <String>{};
     await for (var songs in source.allSongs()) {
       ids.addAll(songs.map((e) => e.id.value));
       await db.saveSongs(songs);

lib/services/sync_service.g.dart

@@ -6,7 +6,7 @@ part of 'sync_service.dart';
 // RiverpodGenerator
 // **************************************************************************
 
-String _$syncServiceHash() => r'2b8da374c3143bc56f17115440d57bc70468a17e';
+String _$syncServiceHash() => r'58ebee4e6f055b64ee6789ae43d63c0e15c679e0';
 
 /// See also [SyncService].
 @ProviderFor(SyncService)