downloads: base album/artist progress on completed tracks

The aggregate summed bytes over only the currently active songs, so it
reset each time a track finished and the next one started. Count completed
tracks (plus the fraction of each running track) over the node's full track
count instead, so it climbs one track at a time.
This commit is contained in:
austinried
2026-10-04 00:30:07 +00:00
parent 5e074db834
commit 196733f9a7
2 changed files with 24 additions and 7 deletions
@@ -146,13 +146,14 @@ fun DownloadsScreen(
tree.artists.forEach { artist ->
val artistKey = "artist:${artist.id}:${artist.name}"
item(key = artistKey) {
val active = activeDownloads(artist.albums.flatMap { it.songs })
val songs = artist.albums.flatMap { it.songs }
val active = activeDownloads(songs)
NodeRow(
name = artist.name,
subtitle = "${artist.albums.size} albums · ${size(artist.bytes)}",
expanded = artistKey in expanded,
indent = 0,
progress = active.progress(),
progress = nodeProgress(songs),
onToggle = { expanded = expanded.toggle(artistKey) },
onDelete = {
onDelete(
@@ -176,7 +177,7 @@ fun DownloadsScreen(
subtitle = "${album.songs.size} songs · ${size(album.bytes)}",
expanded = albumKey in expanded,
indent = 1,
progress = active.progress(),
progress = nodeProgress(album.songs),
onToggle = { expanded = expanded.toggle(albumKey) },
onDelete = {
onDelete(
@@ -277,10 +278,12 @@ private fun NodeRow(
private fun activeDownloads(songs: List<DownloadedSong>): List<DownloadedSong> =
songs.filter { it.status == DownloadStatus.Queued || it.status == DownloadStatus.Running }
private fun List<DownloadedSong>.progress(): Float? {
if (isEmpty()) return null
val total = sumOf { it.total }
return if (total > 0) (sumOf { it.bytes }.toFloat() / total).coerceIn(0f, 1f) else 0f
internal fun nodeProgress(songs: List<DownloadedSong>): Float? {
val active = activeDownloads(songs)
if (active.isEmpty() || songs.isEmpty()) return null
val completed = songs.count { it.status == DownloadStatus.Completed }
val partial = active.sumOf { (it.progress ?: 0f).toDouble() }
return ((completed + partial) / songs.size).toFloat().coerceIn(0f, 1f)
}
@Composable
@@ -3,6 +3,7 @@ package com.subtracks.ui.downloads
import com.subtracks.data.model.DownloadStatus
import com.subtracks.data.model.DownloadedSong
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNull
import org.junit.Test
class DownloadTreeTest {
@@ -44,6 +45,19 @@ class DownloadTreeTest {
assertEquals("Unknown album", artist.albums.single().name)
}
@Test
fun nodeProgressCountsCompletedTracksRatherThanBytes() {
val songs =
listOf(
song("s1", "One", "ar1", "Artist", "al1", "Album", size = 100),
song("s2", "Two", "ar1", "Artist", "al1", "Album", size = 50)
.copy(status = DownloadStatus.Running, bytes = 50, total = 100),
)
assertEquals(0.75f, nodeProgress(songs)!!, 0.0001f)
assertNull(nodeProgress(listOf(song("s3", "Three", "ar1", "Artist", "al1", "Album", size = 1))))
}
private fun song(
id: String,
title: String,